Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please respect the standard variables BUILD_STATIC_LIBS and BUILD_SHARED_LIBS #223

Open
yurivict opened this issue Nov 20, 2018 · 8 comments

Comments

@yurivict
Copy link

Some systems, like FreeBSD, don't install static libs. Some other people might only want static libs.

@janisozaur
Copy link

There's only BUILD_SHARED_LIBS, no such thing as BUILD_STATIC_LIBS

@yurivict
Copy link
Author

BUILD_STATIC_LIBS is maybe not documented, but its search returns a lot of hits, and it makes sense to use it.

@janisozaur
Copy link

It is not documented because it is not recognised as a valid option and "a lot of hits" doesn't sound like a valid argument, I can produce that for nearly any statement. That's in contrast to BUILD_SHARED_LIBS which is well known, documented and relied upon and should be supported.

@yurivict
Copy link
Author

How do I disable static libs then?

@janisozaur
Copy link

By referring to docs and setting BUILD_SHARED_LIBS to the appropriate value.

@yurivict
Copy link
Author

yurivict commented Nov 20, 2018

Setting BUILD_SHARED_LIBS=ON still builds static libs in OctoMap.
Do you really think that I asked here without trying?
You have separate explicit targets for shared and static libs, and don't even respect BUILD_SHARED_LIBS as it is documented.

@janisozaur
Copy link

That's because BUILD_SHARED_LIBS is not respected properly yet, I'm sorry if my previous comment was misleading about that.

@ahornung
Copy link
Member

Any chance for a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants