Added activity indicator #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zfoltin
requested changes
Nov 15, 2016
| @@ -158,6 +163,10 @@ class ItemBaseController<T: UIView>: UIViewController, ItemController, UIGesture | |||
|
|
|||
| self.view.addSubview(scrollView) | |||
| scrollView.addSubview(itemView) | |||
|
|
|||
|
|
|||
zfoltin
approved these changes
Nov 15, 2016
|
I understand that this fix is not included in 4.0. Just wondering - are there any releases planed for the near future with this PR included? |
|
I am also expecting this feature could you guys let us when can we expect this feature to be included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added activity indicator to
ItemBaseController. Indicator appears during fetching item. Style of indicator is taken fromGalleryConfiguration.