Allow extensibility through using a custom GalleryItem #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krisiacik
requested changes
Nov 13, 2016
| } | ||
|
|
||
| return GalleryItem.custom(fetchImageBlock: myFetchImageBlock, getViewController: getViewController) | ||
| } |
There was a problem hiding this comment.
I would rename the argument name to itemViewController
There was a problem hiding this comment.
👍 changed it to itemViewControllerBlock
|
I made ItemBaseController public so it can be inherited from Now there is still an issue - in the example the displaced view animations don't work on this item :( |
|
They should work...I don't see any reason why not..did you implement the displaced Datasource? |
* 'master' of https://github.com/MailOnline/ImageViewer: Add warning about 3.1 Fix typo Cleanup README.md Add CHANGELOG.md
…stom Changing a few more things to public to make GalleryItem.custom work
|
It was to do with not setting the |
* 'master' of https://github.com/MailOnline/ImageViewer: Slight change to follow convention Gallery not clipped to bounds Remove extra empty line Added activity indicator to ItemBaseController Unnecessary white space removed PR suggestions followed Overlay view added to back of the gallery instead of the original view controller Fix executing launchedCompletion block
Krisiacik
approved these changes
Nov 15, 2016
|
Looks good...if it indeed works, let's merge merge merge. And win win win. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
.customGalleryItem type, people will be able to use theirUIImageViewsubclasses in the galleryExample in the example project. Feedback is welcome
PS: hopefully helps with #56