Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple materials and ingredients ids from processes ids #976

Open
vjousse opened this issue Mar 24, 2025 · 0 comments
Open

Decouple materials and ingredients ids from processes ids #976

vjousse opened this issue Mar 24, 2025 · 0 comments

Comments

@vjousse
Copy link
Collaborator

vjousse commented Mar 24, 2025

🔧 Problem

The id fields used in materials.json and in ingredients.json are the same than the corresponding processes.json entries and are used to make the link between the files. It implies than 2 different ingredients can’t be linked to the same process id.

🍰 Solution

Keep the same value for the id on the ingredients.json and materials.json files to avoid breaking the public API. Re-generate the ids of the processes.json files and add a processId field to ingredients.json and to materials.json that will reference the newly generated ids.

🚨 Points to watch/comments

Some process ids are used by the public food API (for cooking), so it will require a breaking change in the API versioning.

🏝️ How to test

TODO

@vjousse vjousse moved this to Backlog in Ecobalyse Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant