Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syntax of margin input with lists #8

Open
haroine opened this issue Jul 7, 2018 · 0 comments
Open

Improve syntax of margin input with lists #8

haroine opened this issue Jul 7, 2018 · 0 comments

Comments

@haroine
Copy link
Collaborator

haroine commented Jul 7, 2018

The idea is to change the recommended margin input method to something like:

marginList <- list(
"categ" = c(0.35, 0.4, 0.25),
"sexe" = c(0.60, 0.40),
"service" = c(0.45, 0.55),
"salaire" = 470000
)

  • Add tests with the list method, with categorical and continuous variables

  • Modify addMargin

  • marginMatrix becomes an ambiguous parameter name: consider changing it (but ensure retrocompatibility!)

  • Change recommended way of integrating margins in the docs

Thanks to Toby Hocking for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant