findPlacesNearPoint does not use abort signal

[mpayson]

Describe the bug

findPlacesNearPoint does not use the abort signal that is passed to it

Reproduction

The following code snippet logs the response, rather than an abort error

import { ApiKeyManager } from "@esri/arcgis-rest-request";
import { findPlacesNearPoint } from "@esri/arcgis-rest-places";

const apiKey = "<replace me>";

const abortController = new AbortController();
findPlacesNearPoint({
  x: -73.735152,
  y: 40.9384275,
  radius: 1600 * 5, // 5 miles in meters
  categoryIds: ["4d4b7105d754a06372d81259"], // Schools
  authentication: ApiKeyManager.fromKey(apiKey),
  signal: abortController.signal,
})
  .then((response) => {
    console.log(response);
  })
  .catch((error) => {
    console.error(error);
  });

abortController.abort();

Logs

System Info

"@esri/arcgis-rest-places": "1.2.0"

Additional Information

No response

[patrickarlt]

@gavinr it looks like signal, credentials, hideToken and suppressWarnings are all missing from https://github.com/Esri/arcgis-rest-js/blob/main/packages/arcgis-rest-request/src/utils/append-custom-params.ts#L14 which is why they aren't getting passed thorough down to request internally.

Since this could have a lot of long reaching implications do we want to hold this until REST JS v5 when we refactor options anyway?

[gavinr-maps]

@patrickarlt sounds reasonable to me. I've created a new milestone to start tracking v5 items: https://github.com/Esri/arcgis-rest-js/milestone/3