Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align node markers with existing software #2157

Open
visr opened this issue Mar 18, 2025 · 0 comments
Open

Align node markers with existing software #2157

visr opened this issue Mar 18, 2025 · 0 comments
Labels
python Relates to one of the Ribasim python packages QGIS Ribasim QGIS plugin

Comments

@visr
Copy link
Member

visr commented Mar 18, 2025

We currently use these icons for the different node types:

Image

The image above are the QGIS QML markers defined here:
https://github.com/Deltares/Ribasim/blob/v2025.2.0/python/ribasim/ribasim/styles/NodeStyle.qml
We also have icons defined for Ribasim Python's model.plot(), they are defined separately but made to appear the same:
https://github.com/Deltares/Ribasim/blob/v2025.2.0/python/ribasim/ribasim/geometry/node.py#L105-L141

The design of these markers has grown organically and has not received too much thought. For node types that are similar to node types in SOBEK or D-Hydro, it would make sense to align where possible. Many users of these software package can dream these icons, and offering familiar icons will help them understand models.

Even if we decide to not align, it would be good to review the markers, as for instance LevelBoundary and Outlet are very hard to distinguished. And ideally verify that they can be distinguished by colorblind people.

@visr visr added python Relates to one of the Ribasim python packages QGIS Ribasim QGIS plugin labels Mar 18, 2025
@github-project-automation github-project-automation bot moved this to To do in Ribasim Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Relates to one of the Ribasim python packages QGIS Ribasim QGIS plugin
Projects
Status: To do
Development

No branches or pull requests

1 participant