Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release file-references in Docs #1549

Closed
gijsber opened this issue Jun 12, 2024 · 2 comments
Closed

Update release file-references in Docs #1549

gijsber opened this issue Jun 12, 2024 · 2 comments
Labels
CI/CD Continuous Integration/Continuous deployment documentation Improvements or additions to documentation

Comments

@gijsber
Copy link
Contributor

gijsber commented Jun 12, 2024

In the release we produce:

  • ribasim_linux.zip
  • ribasim_windows.zip

On the docs page (https://deltares.github.io/Ribasim/tutorials/index.md) we reference:

  • ribasim_cli_linux.zip
  • ribasim_cli_windows.zip

I do not know what filename is preferred, but I do know that it would be good if it is the same :-)
@gijsber gijsber added documentation Improvements or additions to documentation CI/CD Continuous Integration/Continuous deployment labels Jun 12, 2024
@gijsber gijsber added this to Ribasim Jun 12, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Jun 12, 2024
@gijsber gijsber moved this from To do to Sprint backlog in Ribasim Jun 12, 2024
@visr
Copy link
Member

visr commented Jun 12, 2024

Yeah the former is preferred, we removed cli from the name when we started bundling libribasim.dll and ribasim.exe.

@gijsber gijsber changed the title Mismatch between release-zip filename and reference in Docs Update release file-references in Docs Jun 12, 2024
@visr
Copy link
Member

visr commented Jun 13, 2024

Fixed in #1548

@visr visr closed this as completed Jun 13, 2024
@github-project-automation github-project-automation bot moved this from Sprint backlog to ✅ Done in Ribasim Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD Continuous Integration/Continuous deployment documentation Improvements or additions to documentation
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@visr @gijsber