Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't prevent close tab with confirm #828

Merged
merged 2 commits into from
Nov 21, 2022
Merged

fix: can't prevent close tab with confirm #828

merged 2 commits into from
Nov 21, 2022

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Nov 21, 2022

简介

  • 修复无法在关闭 tab 之前插入 confirm 的问题

Resolved #737

主要变更

把 controller 里的默认行为放到 default extensions 里,支持用户通过 event 阻止事件链传递

@mortalYoung mortalYoung added the bug Something isn't working label Nov 21, 2022
@mortalYoung mortalYoung self-assigned this Nov 21, 2022
@mortalYoung mortalYoung requested a review from wewoor November 21, 2022 08:24
@mortalYoung mortalYoung changed the title fix: can't pevent close tab with confirm fix: can't prevent close tab with confirm Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 91.07% // Head: 91.15% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (f959a29) compared to base (d1cdbe1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   91.07%   91.15%   +0.07%     
==========================================
  Files         180      180              
  Lines        5802     5797       -5     
  Branches     1408     1408              
==========================================
  Hits         5284     5284              
+ Misses        512      507       -5     
  Partials        6        6              
Impacted Files Coverage Δ
src/controller/editor.tsx 46.57% <ø> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 9418d40 into main Nov 21, 2022
@wewoor wewoor deleted the fix/close branch November 21, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: can't prevent default behavior about close tab
2 participants