Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with masking #221

Open
ph-kev opened this issue Mar 15, 2025 · 0 comments
Open

Bug with masking #221

ph-kev opened this issue Mar 15, 2025 · 0 comments

Comments

@ph-kev
Copy link
Member

ph-kev commented Mar 15, 2025

In make_lonlat_mask, the function should not preprocess the mask if set_to_val is not nothing. In the preprocessing, we should always make the mask into 0 and 1. We should then pass in true_val and false_val into the masking function that is returned. After we generate the appropriate mask (after rounding the values) with the same size as the data we are masking, we replace the 0 and 1 with true_val and false_val if needed. Finally, we return the new OutputVar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant