Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for streaming Ogg Vorbis files #776

Open
a11cf0 opened this issue Feb 22, 2021 · 10 comments
Open

Support for streaming Ogg Vorbis files #776

a11cf0 opened this issue Feb 22, 2021 · 10 comments

Comments

@a11cf0
Copy link

a11cf0 commented Feb 22, 2021

Hello.
Can support for streaming Ogg Vorbis files be addet at least for Windows clients? Previously it was possible with externaal codecs but since V5.4 it's no longer working.

@CoBC
Copy link
Contributor

CoBC commented Feb 22, 2021

I'm totally agree with this, it's a real problem which cause some users to use V5.3 again today just for this feature. But, unfortunately, @bear101 said to me that it's not possible...

@kirill-jjj
Copy link

why is it not possible, you have just done the streaming in ogg opus, and Vorbis is also a free codec, if you really can't do it, what is the reason?

@zstanecic
Copy link
Contributor

Yep, more arguments will be needed, othervise blacklisting old clients on a server side basis should be done...

@jeremyp3
Copy link
Contributor

has this problem been forgotten? we still can't read ogg file on windows

thanks !

@kirill-jjj
Copy link

kirill-jjj commented Jan 18, 2023

I repeat my question. @bear101, @CoBC Why is it not possible to stream ogg vorbis files? licensing problems? hard code? what exactly prevents adding the most popular format after aac? you added opus with the same license.

@bear101
Copy link
Contributor

bear101 commented Jan 18, 2023

@kirill-jjj You can come an babysit my kids for a week then I'll have time to look into it.

@kirill-jjj
Copy link

@bear101, sorry, I was asking about the impossibility, not why it hasn't been done yet.

@cyrmax
Copy link

cyrmax commented Jan 19, 2023

Hello, @bear101.
I would be glad to babysit your kids for a some time if I had such an oportunity.
And I understand that lack of time can freeze the development.
But here we are not talking about free time to implement a feature. We are talking about the fact that you say that implementation is impossible.
I know c++ a little and cannot contribute to TeamTalk but I know at least two or three third-party libraries which could help you in decoding vorbis.

We do not force you to implement this feature ASAP. We just ask to not tell that it is impossible and put this implementation to your backlog.

@CoBC
Copy link
Contributor

CoBC commented Jan 19, 2023

As this issue is still open, I think no one has sais that it is really impossible now. When I commented on this issue for the first time, I said that @bear101 told me that it is impossible, but it's my mistake, the real words it's more complicated that really impossible, so this will probably be done in the future :)

@bear101
Copy link
Contributor

bear101 commented Jan 21, 2023

It will take a couple of days to implement this. Unfortunately I haven't had the time to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants