[deduplication] Only treat "$ref" as reference if value is string (#5088)

- Fixes #5028

Author: mikeharder

packages/extensions/core/CHANGELOG.json

@@ -1,6 +1,18 @@
 {
   "name": "@autorest/core",
   "entries": [
+    {
+      "version": "3.10.4",
+      "tag": "@autorest/core_v3.10.4",
+      "date": "Fri, 14 Mar 2025 16:49:52 GMT",
+      "comments": {
+        "patch": [
+          {
+            "comment": "[deduplication] Only treat \"$ref\" as reference if value is string"
+          }
+        ]
+      }
+    },
     {
       "version": "3.10.3",
       "tag": "@autorest/core_v3.10.3",

packages/extensions/core/CHANGELOG.md

@@ -1,6 +1,13 @@
 # Change Log - @autorest/core
 
-This log was last generated on Thu, 31 Oct 2024 00:11:17 GMT and should not be manually modified.
+This log was last generated on Fri, 14 Mar 2025 16:49:52 GMT and should not be manually modified.
+
+## 3.10.4
+Fri, 14 Mar 2025 16:49:52 GMT
+
+### Patches
+
+- [deduplication] Only treat "$ref" as reference if value is string
 
 ## 3.10.3
 Thu, 31 Oct 2024 00:11:17 GMT

packages/extensions/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autorest/core",
-  "version": "3.10.3",
+  "version": "3.10.4",
   "description": "AutoRest Core Module",
   "engines": {
     "node": ">=12.0.0"
@@ -49,7 +49,7 @@
     "@azure-tools/async-io": "~3.0.0",
     "@azure-tools/codegen": "~2.10.0",
     "@azure-tools/datastore": "~4.8.0",
-    "@azure-tools/deduplication": "~3.2.1",
+    "@azure-tools/deduplication": "~3.2.2",
     "@azure-tools/extension": "~3.7.1",
     "@azure-tools/json": "~1.3.0",
     "@azure-tools/jsonschema": "~1.3.0",

packages/libs/deduplication/CHANGELOG.json

@@ -1,6 +1,18 @@
 {
   "name": "@azure-tools/deduplication",
   "entries": [
+    {
+      "version": "3.2.2",
+      "tag": "@azure-tools/deduplication_v3.2.2",
+      "date": "Fri, 14 Mar 2025 06:11:23 GMT",
+      "comments": {
+        "patch": [
+          {
+            "comment": "Only treat \"$ref\" as reference if value is string"
+          }
+        ]
+      }
+    },
     {
       "version": "3.2.1",
       "tag": "@azure-tools/deduplication_v3.2.1",

packages/libs/deduplication/CHANGELOG.md

@@ -1,6 +1,13 @@
 # Change Log - @azure-tools/deduplication
 
-This log was last generated on Wed, 28 Feb 2024 18:02:21 GMT and should not be manually modified.
+This log was last generated on Fri, 14 Mar 2025 06:11:23 GMT and should not be manually modified.
+
+## 3.2.2
+Fri, 14 Mar 2025 06:11:23 GMT
+
+### Patches
+
+- Only treat "$ref" as reference if value is string
 
 ## 3.2.1
 Wed, 28 Feb 2024 18:02:21 GMT

packages/libs/deduplication/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure-tools/deduplication",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "description": "Deduplication of elements in OpenAPI 3 documents",
   "main": "./dist/main.js",
   "typings": "./dist/main.d.ts",

packages/libs/deduplication/src/main.ts

@@ -400,11 +400,11 @@ export class Deduplicator {
         continue;
       }
 
-      if (key === "$ref") {
+      if (key === "$ref" && typeof value === "string") {
         const refParts = value.split("/");
         const componentUid = refParts.pop();
         const type = refParts.pop();
-        await this.deduplicateComponent(componentUid, type);
+        await this.deduplicateComponent(componentUid!, type!);
       } else if (value && typeof value === "object") {
         await this.crawlObject(value);
       }