Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Garm uses the generalized cert-reloader once implemented #53

Open
mlajkim opened this issue Dec 13, 2024 · 0 comments
Open

Refactor: Garm uses the generalized cert-reloader once implemented #53

mlajkim opened this issue Dec 13, 2024 · 0 comments
Labels
refactor Changes without functional changes, or api changes)

Comments

@mlajkim
Copy link
Contributor

mlajkim commented Dec 13, 2024

Background

To implement an X.509 readable Garm to replace the deprecated ntoken,
we've designed Garm to use the cert-reloader for reading local X.509 certificates and their keys.

Since there was no generalized library available,
we directly copied the code from athenz/k8s-athenz-sia. You can view the implementation with TODOs here:
https://github.com/AthenZ/garm/blob/master/service/cert-reloader.go#L15-L20

What should be done?

  • Bring the generalized cert-reloader once implemented
@mlajkim mlajkim added the refactor Changes without functional changes, or api changes) label Dec 13, 2024
@mlajkim mlajkim changed the title Refactor: Garm uses the Refactor: Garm uses the generalized cert-reloader once implemented Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes without functional changes, or api changes)
Projects
None yet
Development

No branches or pull requests

1 participant