Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore addAsset tests #10011

Closed
turadg opened this issue Aug 31, 2024 · 0 comments · Fixed by #10058
Closed

restore addAsset tests #10011

turadg opened this issue Aug 31, 2024 · 0 comments · Fixed by #10058
Assignees
@turadg
Labels
enhancement New feature or request technical-debt

Comments

@turadg
Copy link
Member

turadg commented Aug 31, 2024

What is the Problem Being Solved?

The addAssets tests started failing with the introduction of elide-comments. (discussion)

Description of the Design

Put them in,

If that's too big a lift, get them working again in bootstrap tests

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
@turadg turadg added enhancement New feature or request technical-debt labels Aug 31, 2024
@turadg turadg self-assigned this Sep 9, 2024
@turadg turadg mentioned this issue Sep 10, 2024
Merged
@mergify mergify bot closed this as completed in #10058 Sep 10, 2024
@mergify mergify bot closed this as completed in 00f86bb Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
enhancement New feature or request technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10011 restore addAsset tests Agoric/agoric-sdk
1 participant
@turadg