-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tibanna instance type error with snakemake #382
Comments
It looks like you are trying to launch one of these instance types: |
Thanks for reverting. Here is what I tried now
The error
|
Hm... not in Tibanna. How does your test.yaml look like? |
Here is what I have
|
Looking at the Snakemake docs, do you have a |
No, nothing on my side. I don't have a config file. |
Hi, As a follow-up when I tried to use the api. I get this following error.
Here is my Snakefile
Here is my config json
Please let me know if it helps. Thank you. |
Hi, Just wondering if you had a chance to take a look at the errors. Please let me know if you need any further information. Thank you. |
Hi @Bioinf-usr, your shell command doesn't look executable: |
Hi, Thanks you are right, that was an issue but even after fixing it. I am running into another error while using the api. I used the following command to get the error log.
Below is the error.
Here is my command
My test.json
Here is my snakefile
Hope it helps. Please note that this is only for the api. The problem with using snakemake as a standalone is still the same. Thank you. |
Try putting an old tag to |
I'm encountering a similar error. It seems like snakemake/tibanna is trying to use an instance_type that doesn't exist. It isn't obvious where that specific instance_type is coming from though. Relevant messages from cloudwatch logs below
...It sure doesn't seem like "cr1.8xlarge" is coming from snakemake, as it isn't in any of the configs, but I can't see where it would be coming from within Tibanna either. |
Attempting to manually set instance_type didn't work. Relevant cloudwatch log messages below....
|
Hm... Could you remove
from the input and only specify the instance type? Also, make sure the instance type you choose actually exists in |
The config is being automatically generated by snakemake. I can't remove those fields. Mostly I want to know where "cr1.8xlarge" is coming from. Is it snakemake or tibanna that is trying to match ec2 type based on resources? |
I see. It's probably coming from here. Since I will bring this up internally. This is certainly something we need to look at. |
It may be worth clarifying that "cr1.8xlarge" does not appear to be an instance type anymore. It doesn't exist in any of the regions I've checked and Amazon now lists it as a "previous generation instance" After poking around, looks like this is the csv that needs to be updated... |
Yeah, I briefly looked at it. Definitely needs an update. Thanks for bringing the issue to our attention. |
Awesome!! great to see this issue being addressed. Would be happy to do some debugging if needed. Thanks!! |
Please do not use version 3.0.0 or 3.1.0. We identified a critical bug that can cause inflated costs when running spot. We are working on a solution. |
Please use v3.2.1 (or higher) from now on. We are looking at the outdated instance types next. |
Can I also recommend that when instance_type is set, tibanna should skip trying to automatically determine instance type? This current behavior strikes me as counterintuitive and undesirable. |
Version 3.3.0 should fix this issue. Furthermore, when |
I've upgraded to 3.3 and think the update has resolved all outstanding issues. I'm not the person who opened this issue, but I'd call it closed. |
I am running on 4.0.0 and running into the same issue described above, an outdated CSV (even in the latest benchmark release Benchmark-4dn-0.5.23. Using snakemake 7.3.1, with the --tibanna option. |
Which instance type that is causing issues? |
from the run_task_awsem_* cloudwatch logs: [ERROR] ClientError: An error occurred (InvalidInstanceType) when calling the DescribeInstanceTypes operation: The following supplied instance types do not exist: [r6a.xlarge, r6id.xlarge] fwiw, the file on the benchmark github (https://github.com/SooLee/Benchmark/blob/master/Benchmark/aws/Amazon%20EC2%20Instance%20Comparison.csv) does seem to be up-to-date (at least seems to contain valid instance types), but the package version with Benchmark-4dn-0.5.23 contains an outdated version. Unsure how/if this is tweakable without manually uploading my own lambda function with a corrected version of this file. |
I think the Benchmark-4dn-0.5.23 list is fine but the problem is that this list is not region specific. It returns instance types that are valid in |
ah, great to know, might consider migrating to us-east-1 if that list will be kept up-to-date. Maybe this is an issue better raised in Benchmark, but could imagine a fix might take some adjustments to both. |
Hi,
I am trying to use tibanna to launch snakemake workflows on AWS. However, I am constantly running into an error (as I can see on the cloud watch)
{ "error": "ClientError", "cause": { "errorMessage": "An error occurred (InvalidInstanceType) when calling the DescribeInstanceTypes operation: The following supplied instance types do not exist: [m1.medium, m3.medium, t4g.medium.search]", "errorType": "ClientError", "stackTrace": [ " File \"/var/task/service.py\", line 20, in handler\n return run_task(event)\n", " File \"/var/task/tibanna/run_task.py\", line 63, in run_task\n execution = Execution(input_json)\n", " File \"/var/task/tibanna/ec2_utils.py\", line 374, in __init__\n self.create_instance_type_list()\n", " File \"/var/task/tibanna/ec2_utils.py\", line 426, in create_instance_type_list\n results = ec2.describe_instance_types(\n", " File \"/var/task/botocore/client.py\", line 530, in _api_call\n return self._make_api_call(operation_name, kwargs)\n", " File \"/var/task/botocore/client.py\", line 960, in _make_api_call\n raise error_class(parsed_response, operation_name)\n" ] } }
Here are my versions:
snakemake version: 7.20.0
tibanna version: 3.1.0
Python version: 3.7.12
Below is the command used:
snakemake --tibanna --tibanna-config spot_instance=true behavior_on_capacity_limit=retry_without_spot instance_type=t4g.medium.search availability_zone=ap-south-1 --default-remote-prefix=<bucketname> -s test.yaml --jobs 1
Could you please let me know if I'm missing something?
Thank you.
The text was updated successfully, but these errors were encountered: